Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 460383004: For a CPDF_Color object, when set a new pattern to it, disconnect its link with the old pattern (Closed)

Created:
6 years, 4 months ago by Bo Xu
Modified:
6 years, 4 months ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

For a CPDF_Color object, when set a new pattern to it, disconnect its link with the old pattern This patch is related to https://pdfium.googlesource.com/pdfium/+/1b9c5c4dc41956b8c5ab17b9a882adf8a2513768 BUG=402260 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/87708e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bo Xu
Tom, please take a look at this one. Thanks!
6 years, 4 months ago (2014-08-12 21:07:01 UTC) #1
Tom Sepez
lgtm
6 years, 4 months ago (2014-08-12 21:34:21 UTC) #2
Bo Xu
6 years, 4 months ago (2014-08-12 21:36:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 87708e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698