Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 460363002: Record DevTools metadata events on worker threads when starting recoring tracing based Timeline (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, sergeyv
CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Record DevTools metadata events on worker threads when starting recoring tracing based Timeline This events will be used to figure out if given worker thread is started by the page being profiled and if so we will show messages in the worker on the same Timeline. BUG=401895 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180072

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -10 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/inspector/timeline/tracing/resources/worker.js View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/inspector/timeline/tracing/worker-events.html View 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/inspector/timeline/tracing/worker-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.cpp View 5 chunks +12 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScopeProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 4 months ago (2014-08-12 12:33:38 UTC) #1
alph
lgtm https://codereview.chromium.org/460363002/diff/1/Source/core/inspector/InspectorWorkerAgent.cpp File Source/core/inspector/InspectorWorkerAgent.cpp (right): https://codereview.chromium.org/460363002/diff/1/Source/core/inspector/InspectorWorkerAgent.cpp#newcode207 Source/core/inspector/InspectorWorkerAgent.cpp:207: for (DedicatedWorkers::iterator it = m_dedicatedWorkers.begin(); it != m_dedicatedWorkers.end(); ...
6 years, 4 months ago (2014-08-12 12:54:33 UTC) #2
yurys
https://codereview.chromium.org/460363002/diff/1/Source/core/inspector/InspectorWorkerAgent.cpp File Source/core/inspector/InspectorWorkerAgent.cpp (right): https://codereview.chromium.org/460363002/diff/1/Source/core/inspector/InspectorWorkerAgent.cpp#newcode207 Source/core/inspector/InspectorWorkerAgent.cpp:207: for (DedicatedWorkers::iterator it = m_dedicatedWorkers.begin(); it != m_dedicatedWorkers.end(); ++it) ...
6 years, 4 months ago (2014-08-12 13:15:20 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-12 13:15:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/460363002/20001
6 years, 4 months ago (2014-08-12 13:16:11 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 14:16:57 UTC) #6
Message was sent while issue was closed.
Change committed as 180072

Powered by Google App Engine
This is Rietveld 408576698