Source/core/html/HTMLFormControlElement.h - Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/number/number-validity-badinput-expected.txt ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormControlElement.h

diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h

index d357cf131b894a638187a99ab3e275c251091f2b..bc8f2e0555d4ba86be4dd792b2e5f11001cf3488 100644

--- a/Source/core/html/HTMLFormControlElement.h

+++ b/Source/core/html/HTMLFormControlElement.h

@@ -181,6 +181,8 @@ private:

// Cache of valid().

// But "candidate for constraint validation" doesn't affect m_isValid.

bool m_isValid : 1;

+ // Dirty flag that controls updating valid() cache.

+ bool m_validityIsDirty : 1;

bool m_wasChangedSinceLastFormControlChangeEvent : 1;

bool m_wasFocusedByMouse : 1;

« no previous file with comments | « LayoutTests/fast/forms/number/number-validity-badinput-expected.txt ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »