Source/core/html/HTMLTextAreaElement.h - Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | Source/core/html/HTMLTextAreaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextAreaElement.h

diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h

index b5f9ffb4b5f7320263d27d014696545f513cf86c..a8804fc06bd408b0757bcbf2a9ed51a085ac099b 100644

--- a/Source/core/html/HTMLTextAreaElement.h

+++ b/Source/core/html/HTMLTextAreaElement.h

@@ -120,6 +120,8 @@ private:

virtual bool matchesReadOnlyPseudoClass() const OVERRIDE;

virtual bool matchesReadWritePseudoClass() const OVERRIDE;

+ virtual void detach(const AttachContext&) OVERRIDE;

bool valueMissing(const String& value) const { return isRequiredFormControl() && !isDisabledOrReadOnly() && value.isEmpty(); }

bool tooLong(const String&, NeedsToCheckDirtyFlag) const;