Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index 32c5ab6b321b535bd9887ea3b07c960cbb90c6dd..154f56a4abf9aa8d909fce1c8a563350562495c1 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -489,8 +489,8 @@ void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedVal

InputType::setValue(sanitizedValue, valueChanged, eventBehavior);

DateTimeEditElement* edit = dateTimeEditElement();

if (valueChanged || (sanitizedValue.isEmpty() && edit && edit->anyEditableFieldsHaveValues())) {

- element().updateView();

element().setNeedsValidityCheck();

+ element().updateView();

}

« Source/core/html/HTMLTextAreaElement.cpp ('K') | « Source/core/html/HTMLTextAreaElement.cpp ('k') | no next file » | no next file with comments »