Source/core/html/HTMLInputElement.cpp - Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.h » ('j') | Source/core/html/HTMLTextAreaElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 5d9b56ce74408ae5f8becae7c8b3cc747c925f01..82460195a68ac3d4c4389bfd1d779d632c6e68b0 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -454,6 +454,7 @@ void HTMLInputElement::updateType()

}

m_needsToUpdateViewValue = true;

+ setNeedsValidityCheck();

m_inputTypeView->updateView();

if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttributes()) {

@@ -474,7 +475,6 @@ void HTMLInputElement::updateType()

addToRadioButtonGroup();

- setNeedsValidityCheck();

notifyFormStateChanged();

}