Source/core/html/HTMLTextAreaElement.cpp - Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Side by Side Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 460343004: Fix update of validity cache value, so that it reflects the correct state of any FormControlElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)	7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 554 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
565 bool HTMLTextAreaElement::isInteractiveContent() const	565 bool HTMLTextAreaElement::isInteractiveContent() const

566 {	566 {

567 return true;	567 return true;

568 }	568 }

569	569

570 bool HTMLTextAreaElement::supportsAutofocus() const	570 bool HTMLTextAreaElement::supportsAutofocus() const

571 {	571 {

572 return true;	572 return true;

573 }	573 }

574	574

	575 void HTMLTextAreaElement::detach(const AttachContext& context)

	576 {

	577 // Since we do a lazy update from renderer, do it if we have

	578 // failed to do a lazy update. Updated value will be needed

	579 // while saving the form control state.
	tkent 2014/09/03 08:04:44 I don't understand the comment. Does the code to s I don't understand the comment. Does the code to save form control value use m_value instead of value()? spartha 2014/09/03 08:50:57 It uses value(). It tries to update m_value in the Show quoted text On 2014/09/03 08:04:44, tkent wrote: > I don't understand the comment. > Does the code to save form control value use m_value instead of value()? It uses value(). It tries to update m_value in the process. This causes the assertion for renderer() to fail, as the element is already detached. I guess this issue got masked by the call to setNeedsValidityCheck in subTreeChanged() which would call value(). #0 0x7f17d2e2dcfe base::debug::StackTrace::StackTrace() #1 0x7f17d2e2d830 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f17c3be7340 <unknown> #3 0x7f17ca368c16 blink::HTMLTextAreaElement::updateValue() #4 0x7f17ca367a17 blink::HTMLTextAreaElement::value() #5 0x7f17ca3679af blink::HTMLTextAreaElement::saveFormControlState() #6 0x7f17ca40bf3c blink::DocumentState::toStateVector() #7 0x7f17caa125de blink::HistoryItem::documentState() #8 0x7f17caa12633 blink::HistoryItem::getReferencedFilePaths() #9 0x7f17c89a4202 blink::WebHistoryItem::getReferencedFilePaths() #10 0x7f17cda40bf7 content::HistoryEntryToPageState() #11 0x7f17cdb8837e content::RenderViewImpl::SendUpdateState() #12 0x7f17cdb882a3 content::RenderViewImpl::UpdateSessionHistory() #13 0x7f17cdb37ee2 content::RenderFrameImpl::didCommitProvisionalLoad() #14 0x00000056e380 content::WebFrameTestProxy<>::didCommitProvisionalLoad() #15 0x00000056f3ed content::WebFrameTestProxy<>::didCommitProvisionalLoad() #16 0x7f17c89250ec blink::FrameLoaderClientImpl::dispatchDidCommitLoad() #17 0x7f17caa0ab79 blink::FrameLoader::receivedFirstData() #18 0x7f17ca9fb5fb blink::DocumentLoader::ensureWriter() #19 0x7f17ca9f9d55 blink::DocumentLoader::commitData() #20 0x7f17ca9f9922 blink::DocumentLoader::finishedLoading() #21 0x7f17ca9fc686 blink::DocumentLoader::maybeLoadEmpty() #22 0x7f17ca9fc7f9 blink::DocumentLoader::startLoadingMainResource() #23 0x7f17caa0ddb9 blink::FrameLoader::loadWithNavigationAction() #24 0x7f17caa0cfa3 blink::FrameLoader::load() tkent 2014/09/03 09:11:27 Thanks. I understand. We should remove ASSERT(ren Thanks. I understand. We should remove ASSERT(renderer()). It's bogus now. spartha 2014/09/03 14:47:33 Done. Show quoted text On 2014/09/03 09:11:27, tkent wrote: > Thanks. I understand. > We should remove ASSERT(renderer()). It's bogus now. Done.
	580 updateValue();

	581 HTMLTextFormControlElement::detach(context);

575 }	582 }

	583

	584 }

OLD	NEW