Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Source/core/html/HTMLTextAreaElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 56 matching lines @@
     enum WrapMethod { NoWrap, SoftWrap, HardWrap };
 
     virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE;
     // FIXME: Author shadows should be allowed
     // https://bugs.webkit.org/show_bug.cgi?id=92608
     virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
 
     void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) const;
     static String sanitizeUserInputValue(const String&, unsigned maxLength);
     void updateValue() const;
-    virtual void setInnerEditorValue(const String&) OVERRIDE;
     void setNonDirtyValue(const String&);
     void setValueCommon(const String&, TextFieldEventBehavior, SelectionOption = NotChangeSelection);
 
     virtual bool supportsPlaceholder() const OVERRIDE { return true; }
     virtual void updatePlaceholderText() OVERRIDE;
     virtual bool isEmptyValue() const OVERRIDE { return value().isEmpty(); }
     virtual bool isEmptySuggestedValue() const OVERRIDE FINAL { return suggestedValue().isEmpty(); }
 
     virtual bool isOptionalFormControl() const OVERRIDE { return !isRequiredFormControl(); }
     virtual bool isRequiredFormControl() const OVERRIDE { return isRequired(); }
@@ skipping 33 matching lines @@
     virtual bool matchesReadWritePseudoClass() const OVERRIDE;
 
     bool valueMissing(const String& value) const { return isRequiredFormControl() && !isDisabledOrReadOnly() && value.isEmpty(); }
     bool tooLong(const String&, NeedsToCheckDirtyFlag) const;
 
     int m_rows;
     int m_cols;
     WrapMethod m_wrap;
     mutable String m_value;
     mutable bool m_isDirty;
-    bool m_valueIsUpToDate;

[spartha, 2014/09/02 14:09:55]

The flag is set in subTreeChanged() and the value was updated in the same call
stack (in the call to valid()). So there was no lazy update happening as such.
This flag has been replaced by a direct call to updateValue(). This change was
needed as we do a lazy update of validity.   

[tkent, 2014/09/03 02:16:35]

Don't change this.  The change will cause performance regression.

[spartha, 2014/09/03 06:14:47]

I have not come across m_valueIsUpToDate being set to false anywhere else, hence
I don't see it doing a lazy update. The call to setNeedsValidtyCheck() in
subTreeChanged() would update the value anyway. Have I missed any other
alternate flow that would benefit from this setup? 

[tkent, 2014/09/03 07:56:43]

- If willValidate() is false, updateValue() shouldn't be called immediately.
- By the lazy evaluation of validity, the number of updateValue() calls would be
reduced. We'll have performance benefit.

     String m_suggestedValue;
 };
 
 } //namespace
 
 #endif