Fix update of validity cache value, so that it reflects the correct state of any FormControlElement.

Source/core/html/HTMLTextAreaElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 65 matching lines @@
 {
     return text.length() + numberOfLineBreaks(text);
 }
 
 HTMLTextAreaElement::HTMLTextAreaElement(Document& document, HTMLFormElement* form)
     : HTMLTextFormControlElement(textareaTag, document, form)
     , m_rows(defaultRows)
     , m_cols(defaultCols)
     , m_wrap(SoftWrap)
     , m_isDirty(false)
-    , m_valueIsUpToDate(true)
 {
     ScriptWrappable::init(this);
 }
 
 PassRefPtrWillBeRawPtr<HTMLTextAreaElement> HTMLTextAreaElement::create(Document& document, HTMLFormElement* form)
 {
     RefPtrWillBeRawPtr<HTMLTextAreaElement> textArea = adoptRefWillBeNoop(new HTMLTextAreaElement(document, form));
     textArea->ensureUserAgentShadowRoot();
     return textArea.release();
 }
@@ skipping 164 matching lines @@
 
 void HTMLTextAreaElement::handleFocusEvent(Element*, FocusType)
 {
     if (LocalFrame* frame = document().frame())
         frame->spellChecker().didBeginEditing(this);
 }
 
 void HTMLTextAreaElement::subtreeHasChanged()
 {
     setChangedSinceLastFormControlChangeEvent(true);
-    m_valueIsUpToDate = false;
+    // Update Value to match the renderer
+    updateValue();
     setNeedsValidityCheck();
     setAutofilled(false);
 
     if (!focused())
         return;
 
     // When typing in a textarea, childrenChanged is not called, so we need to force the directionality check.
     calculateAndAdjustDirectionality();
 
     ASSERT(document().isActive());
@@ skipping 28 matching lines @@
 
 String HTMLTextAreaElement::sanitizeUserInputValue(const String& proposedValue, unsigned maxLength)
 {
     if (maxLength > 0 && U16_IS_LEAD(proposedValue[maxLength - 1]))
         --maxLength;
     return proposedValue.left(maxLength);
 }
 
 void HTMLTextAreaElement::updateValue() const
 {
-    if (m_valueIsUpToDate)
-        return;
-
     ASSERT(renderer());
     m_value = innerEditorValue();
-    const_cast<HTMLTextAreaElement*>(this)->m_valueIsUpToDate = true;
     const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged();
     m_isDirty = true;
     const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility(false);
 }
 
 String HTMLTextAreaElement::value() const
 {
-    updateValue();

[spartha, 2014/09/02 14:09:55]

Replaced by a call from subTreeChanged()

     return m_value;
 }
 
 void HTMLTextAreaElement::setValue(const String& value, TextFieldEventBehavior eventBehavior)
 {
     RefPtrWillBeRawPtr<HTMLTextAreaElement> protector(this);
     setValueCommon(value, eventBehavior);
     m_isDirty = true;
     if (document().focusedElement() == this)
         document().frameHost()->chrome().client().didUpdateTextOfFocusedElementByNonUserInput();
@@ skipping 46 matching lines @@
     notifyFormStateChanged();
     if (eventBehavior == DispatchNoEvent) {
         setTextAsOfLastFormControlChangeEvent(normalizedValue);
     } else {
         if (eventBehavior == DispatchInputAndChangeEvent)
             dispatchFormControlInputEvent();
         dispatchFormControlChangeEvent();
     }
 }
 
-void HTMLTextAreaElement::setInnerEditorValue(const String& value)
-{
-    HTMLTextFormControlElement::setInnerEditorValue(value);
-    m_valueIsUpToDate = true;
-}
-
 String HTMLTextAreaElement::defaultValue() const
 {
     StringBuilder value;
 
     // Since there may be comments, ignore nodes other than text nodes.
     for (Node* n = firstChild(); n; n = n->nextSibling()) {
         if (n->isTextNode())
             value.append(toText(n)->data());
     }
 
@@ skipping 150 matching lines @@
 {
     return true;
 }
 
 bool HTMLTextAreaElement::supportsAutofocus() const
 {
     return true;
 }
 
 }