Issue 460323002: DevTools: Allow dynamic module registration only in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460323002: DevTools: Allow dynamic module registration only in tests (Closed)

Created:
6 years, 4 months ago by apavlov

Modified:
6 years, 4 months ago

Reviewers:
eustas, vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Allow dynamic module registration only in tests Runtime.prototype.registerModule() should not be available publicly, as changes in the configuration require the devtools restart. R=eustas, pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180063

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	LayoutTests/http/tests/inspector/inspector-test.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/layers-test.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/documentation/document-parser.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/inspector/documentation/documentation-url-provider.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/Runtime.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/460323002/1

6 years, 4 months ago (2014-08-12 09:43:58 UTC) #4

Message was sent while issue was closed.

Change committed as 180063

Expand Messages | Collapse Messages