Issue 460303002: libwebp: mips32r6 build fix

Issue 460303002: libwebp: mips32r6 build fix (Closed)

Created:
6 years, 4 months ago by gordanac

Modified:
6 years, 4 months ago

Reviewers:
urvang (Google), jzern, urvang, gordanac

CC:
chromium-reviews, urvang (Google), jzern, skal, vikasa, petar.jovanovic, Paul Lind

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

libwebp: mips32r6 build fix b7e5a5c MIPS: detect mips32r6 and disable mips32r1 code Part of 0524d9e that got missed in previous cherry-pick BUG=400684, 374343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289075

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing include #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	third_party/libwebp/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libwebp/dsp/dsp.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libwebp/utils/bit_reader_inl.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

urvang (Google)

https://codereview.chromium.org/460303002/diff/1/third_party/libwebp/utils/bit_reader_inl.h File third_party/libwebp/utils/bit_reader_inl.h (right): https://codereview.chromium.org/460303002/diff/1/third_party/libwebp/utils/bit_reader_inl.h#newcode26 third_party/libwebp/utils/bit_reader_inl.h:26: I see "#include "../dsp/dsp.h" in the original patch 0524d9e: ...

6 years, 4 months ago (2014-08-12 18:21:40 UTC) #2

gordanac

Sorry, missed it. Here it is now. https://codereview.chromium.org/460303002/diff/1/third_party/libwebp/utils/bit_reader_inl.h File third_party/libwebp/utils/bit_reader_inl.h (right): https://codereview.chromium.org/460303002/diff/1/third_party/libwebp/utils/bit_reader_inl.h#newcode26 third_party/libwebp/utils/bit_reader_inl.h:26: On 2014/08/12 ...

6 years, 4 months ago (2014-08-12 18:47:35 UTC) #3

jzern

lgtm. I didn't see a problem with the r10 beta ndk when I put in ...

6 years, 4 months ago (2014-08-12 19:31:25 UTC) #5

gordanac

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

6 years, 4 months ago (2014-08-12 19:40:13 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/460303002/20001

6 years, 4 months ago (2014-08-12 19:42:19 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-08-12 21:00:47 UTC) #8

Message was sent while issue was closed.

Change committed as 289075

Expand Messages | Collapse Messages