Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 460283003: Revert of Video capture should set visible size and coded size separately. (Closed)

Created:
6 years, 4 months ago by Alpha Left Google
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Video capture should set visible size and coded size separately. (https://codereview.chromium.org/457823003/) Reason for revert: Broke 1080p and 480p tab capture on desktop. Original issue's description: > Video capture should set visible size and coded size separately. > > The coded size should always be rounded up to multiples of 16 pixels to accomodate > alignment requirements of HW encoders, while the visible size reflects the actual > content size. > > BUG=402151 > TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288565 TBR=sergeyu@chromium.org,posciak@chromium.org,hshi@chromium.org NOTREECHECKS=true NOTRY=true BUG=402151 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.cc View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alpha Left Google
Created Revert of Video capture should set visible size and coded size separately.
6 years, 4 months ago (2014-08-12 20:30:04 UTC) #1
hshi1
On 2014/08/12 20:30:04, Alpha wrote: > Created Revert of Video capture should set visible size ...
6 years, 4 months ago (2014-08-12 20:31:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/460283003/1
6 years, 4 months ago (2014-08-12 20:33:10 UTC) #3
Alpha Left Google
On 2014/08/12 20:31:59, hshi1 wrote: > On 2014/08/12 20:30:04, Alpha wrote: > > Created Revert ...
6 years, 4 months ago (2014-08-12 20:33:28 UTC) #4
Alpha Left Google
The CQ bit was unchecked by hclam@chromium.org
6 years, 4 months ago (2014-08-12 20:36:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 20:36:44 UTC) #6
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-12 20:42:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/460283003/1
6 years, 4 months ago (2014-08-12 20:46:45 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 20:50:51 UTC) #9
Message was sent while issue was closed.
Change committed as 289059

Powered by Google App Engine
This is Rietveld 408576698