Fixed misuse of GetProfileByUser in MultiProfileUserController.

Fixed misuse of GetProfileByUser in MultiProfileUserController.

GetProfileByUserUnsafe was called to yearly sometimes, when profile was not
created yet. I replaced GetProfileByUserUnsafe with GetProfileByUser and added
check that it is not NULL.

BUG=361528
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289639

[Nikita (slow), 2014-08-13 09:16:46]

https://codereview.chromium.org/460233004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/users/multi_profile_user_controller.cc
(right):

https://codereview.chromium.org/460233004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/users/multi_profile_user_controller.cc:122: if
(Profile* primary_user_profile =
I worry that if someone cals IsUserAllowedInSession() early when profile is not
available yet he will get cached value i.e. ignoring for instance
NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED /
NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS.

Can you make sure that this value is not cached by caller and once profile is
available it will still be checked?

[dzhioev (left Google), 2014-08-13 16:41:14]

https://codereview.chromium.org/460233004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/users/multi_profile_user_controller.cc
(right):

https://codereview.chromium.org/460233004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/users/multi_profile_user_controller.cc:122: if
(Profile* primary_user_profile =
On 2014/08/13 09:16:46, Nikita Kostylev wrote:
> I worry that if someone cals IsUserAllowedInSession() early when profile is
not
> available yet he will get cached value i.e. ignoring for instance
> NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED /
> NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS.
> 
> Can you make sure that this value is not cached by caller and once profile is
> available it will still be checked?
Checked, nobody caches this value.

[Nikita (slow), 2014-08-13 16:43:39]

lgtm

[dzhioev (left Google), 2014-08-13 17:34:01]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-13 17:35:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/460233004/1

[dzhioev (left Google), 2014-08-13 18:38:52]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-13 18:41:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/460233004/20001

[commit-bot: I haz the power, 2014-08-14 02:07:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-14 08:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-14 08:10:02]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[dzhioev (left Google), 2014-08-14 13:23:10]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-14 13:25:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/460233004/20001

[commit-bot: I haz the power, 2014-08-14 17:40:55]

Committed patchset #2 (20001) as 289639