[Win] Fix the size of the themed new avatar button with the new assets

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
index b23e670975b0cc52050861b72e8572b484f7326b..effd8be4ae7f3463617b1367aaa6493dfabbf696 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
@@ -387,19 +387,17 @@ void OpaqueBrowserFrameViewLayout::LayoutNewStyleAvatar(views::View* host) {
 
   int button_x = host->width() - trailing_button_start_ -
       button_size_with_offset;
-  int button_y = CaptionButtonY(false);
-  // If the window is maximized, the button is 1 pixel too short. Determined
-  // via visual inspection.
-  int extra_height = IsTitleBarCondensed() ? 1 : 0;
+  int button_y = CaptionButtonY(!IsTitleBarCondensed());
 
   trailing_button_start_ += button_size_with_offset;
   minimum_size_for_buttons_ += button_size_with_offset;
 
-  new_avatar_button_->SetBounds(
-      button_x,
-      button_y,
-      label_size.width(),
-      button_y + kCaptionButtonHeightWithPadding + extra_height);
+  // |kCaptionButtonHeightWithPadding| includes a 1px padding that is added

[msw, 2014/08/12 21:48:56]

nit: // Do not include the 1px padding that is added for the caption buttons.

[noms (inactive), 2014/08/12 21:53:41]

:)

Done.

On 2014/08/12 21:48:56, msw wrote:

+  // below the caption buttons.
+  new_avatar_button_->SetBounds(button_x,
+                                button_y,
+                                label_size.width(),
+                                kCaptionButtonHeightWithPadding - 1);
 }
 
 void OpaqueBrowserFrameViewLayout::LayoutAvatar(views::View* host) {