[Win] Fix the size of the themed new avatar button with the new assets

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
index b23e670975b0cc52050861b72e8572b484f7326b..07eca8e292372587297b3d9a7106f9b18784d14a 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
@@ -387,19 +387,18 @@ void OpaqueBrowserFrameViewLayout::LayoutNewStyleAvatar(views::View* host) {
 
   int button_x = host->width() - trailing_button_start_ -
       button_size_with_offset;
-  int button_y = CaptionButtonY(false);
-  // If the window is maximized, the button is 1 pixel too short. Determined
-  // via visual inspection.
-  int extra_height = IsTitleBarCondensed() ? 1 : 0;
+  int button_y = CaptionButtonY(!IsTitleBarCondensed());
 
   trailing_button_start_ += button_size_with_offset;
   minimum_size_for_buttons_ += button_size_with_offset;
 
+  // |kCaptionButtonHeightWithPadding| adds a 1px padding to the height

[msw, 2014/08/12 21:22:56]

Clarify why the 1px matters or remove the comment if it's not pertinent.

[noms (inactive), 2014/08/12 21:44:47]

The comment at the top of the file for kCaptionButtonHeightWithPadding says that
it "adds some padding padding below it", and I've verified that the size of the
caption resources is 18px. I can create kCaptionButtonHeight, but that might be
an overkill. 

Also I forgot to actually include the -1 which is why the comment is there. This
CL is kryptonite.

On 2014/08/12 21:22:56, msw wrote:

+  // of the button.
   new_avatar_button_->SetBounds(
       button_x,

[msw, 2014/08/12 21:22:56]

nit: move this to the line above, indent others to match.

[noms (inactive), 2014/08/12 21:44:47]

Done.

       button_y,
       label_size.width(),
-      button_y + kCaptionButtonHeightWithPadding + extra_height);
+      kCaptionButtonHeightWithPadding);
 }
 
 void OpaqueBrowserFrameViewLayout::LayoutAvatar(views::View* host) {