[Win] Fix the size of the themed new avatar button with the new assets

[Win] Fix the size of the themed new avatar button with the new assets

This CL updates the size of the new avatar button that is needed after updating the resources in this CL:
https://codereview.chromium.org/462043003/

BUG=395798
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289562

[noms (inactive), 2014-08-12 21:09:03]

Hi Mike,

I've moved the actual code part from https://codereview.chromium.org/462043003/
to a separate CL, so I don't have to do any code dcommitting shenanigans.

Please take a look. I think it makes much more sense now.

[msw, 2014-08-12 21:22:56]

Much better, thanks for looking closer.

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:395: //
|kCaptionButtonHeightWithPadding| adds a 1px padding to the height
Clarify why the 1px matters or remove the comment if it's not pertinent.

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:398: button_x,
nit: move this to the line above, indent others to match.

[noms (inactive), 2014-08-12 21:44:47]

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:395: //
|kCaptionButtonHeightWithPadding| adds a 1px padding to the height
The comment at the top of the file for kCaptionButtonHeightWithPadding says that
it "adds some padding padding below it", and I've verified that the size of the
caption resources is 18px. I can create kCaptionButtonHeight, but that might be
an overkill. 

Also I forgot to actually include the -1 which is why the comment is there. This
CL is kryptonite.

On 2014/08/12 21:22:56, msw wrote:
> Clarify why the 1px matters or remove the comment if it's not pertinent.

https://codereview.chromium.org/460233003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:398: button_x,
On 2014/08/12 21:22:56, msw wrote:
> nit: move this to the line above, indent others to match.

Done.

[msw, 2014-08-12 21:48:57]

lgtm with a nit

https://codereview.chromium.org/460233003/diff/70001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/460233003/diff/70001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:395: //
|kCaptionButtonHeightWithPadding| includes a 1px padding that is added
nit: // Do not include the 1px padding that is added for the caption buttons.

[noms (inactive), 2014-08-12 21:53:41]

https://codereview.chromium.org/460233003/diff/70001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/460233003/diff/70001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:395: //
|kCaptionButtonHeightWithPadding| includes a 1px padding that is added
:)

Done.

On 2014/08/12 21:48:56, msw wrote:
> nit: // Do not include the 1px padding that is added for the caption buttons.

[noms (inactive), 2014-08-13 20:31:10]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:33:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/460233003/110001

[commit-bot: I haz the power, 2014-08-14 12:31:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 14:28:44]

Committed patchset #4 (110001) as 289562