Issue 460213002: LeakDetector: Add an expectation for resolve-after-window-close.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460213002: LeakDetector: Add an expectation for resolve-after-window-close.html (Closed)

Created:
6 years, 4 months ago by horo

Modified:
6 years, 4 months ago

Reviewers:
hajimehoshi, kouhei (in TOK)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

LeakDetector: Add an expectation for resolve-after-window-close.html r179771 fixed the crash bug but it didn't fix the leak bug. BUG=400012 TEST=n/a NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180028

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	LayoutTests/LeakExpectations	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

On 2014/08/12 03:17:00, hajimehoshi wrote: > +kouhei > > lgtm lgtm as well

6 years, 4 months ago (2014-08-12 03:55:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/460213002/1

6 years, 4 months ago (2014-08-12 04:04:41 UTC) #5

horo

6 years, 4 months ago (2014-08-14 02:18:57 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/475593003/ by horo@chromium.org.

The reason for reverting is: Fixed by
http://src.chromium.org/viewvc/blink?view=revision&revision=180139.

Expand Messages | Collapse Messages