Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460183002: Removed --disable-device-discovery switch. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, Noam Samuel
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Project:
chromium
Visibility:
Public.

Description

Removed --disable-device-discovery switch. BUG=350219 TBR=thestig Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289189

Patch Set 1 #

Patch Set 2 : Mon 08/11/2014 18:23:33.89 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-12 01:25:40 UTC) #1
Noam Samuel
lgtm
6 years, 4 months ago (2014-08-12 18:36:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/460183002/20001
6 years, 4 months ago (2014-08-12 18:38:46 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 22:27:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 22:33:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3768)
6 years, 4 months ago (2014-08-12 22:33:13 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-12 23:13:09 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-12 23:13:22 UTC) #8
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-12 23:13:52 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-12 23:13:55 UTC) #10
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-12 23:19:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/460183002/20001
6 years, 4 months ago (2014-08-12 23:52:13 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 01:12:58 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 02:17:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1065)
6 years, 4 months ago (2014-08-13 02:17:16 UTC) #15
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-13 02:17:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/460183002/20001
6 years, 4 months ago (2014-08-13 02:18:31 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 03:42:51 UTC) #18
Message was sent while issue was closed. 
Change committed as 289189

Powered by Google App Engine
This is Rietveld 408576698