ui/webui/resources/js/cr.js - Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr.js

Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@C_compiler_pass

Patch Set: define property on prototype, also minor nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java ('K') | « third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr.js

diff --git a/ui/webui/resources/js/cr.js b/ui/webui/resources/js/cr.js

index dbcbb828a5621ad664f3b685529cd16774b5ee8f..c44091c48ab2196363b3cfc87b83d5b2143789f9 100644

--- a/ui/webui/resources/js/cr.js

+++ b/ui/webui/resources/js/cr.js

@@ -75,17 +75,20 @@ var cr = function() {

/**

* Plain old JS property where the backing data is stored as a "private"

* field on the object.

+ * Use only for properties of any type.

Tyler Breisacher (Chromium) 2014/08/13 20:35:43 s/only //

Vitaly Pavlenko 2014/08/13 21:12:04 Done.

JS: 'js',

/**

* The property backing data is stored as an attribute on an element.

+ * Use only for properties of type {string}.

ATTR: 'attr',

/**

* The property backing data is stored as an attribute on an element. If the

* element has the attribute then the value is true.

+ * Use only for properties of type {boolean}.

BOOL_ATTR: 'boolAttr'

};