Issue 460154: Revert 34110 - Fix leak of ShutdownDetector. Broke Mac startup_test....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460154: Revert 34110 - Fix leak of ShutdownDetector. Broke Mac startup_test.... (Closed)

Created:
11 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, asargent_no_longer_on_chrome

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, ben+cc_chromium.org, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 34110 - Fix leak of ShutdownDetector. Broke Mac startup_test. For some reason I thought that nonjoinable threads would always delete their delegates. I was wrong. BUG=http://crbug.com/29675 Review URL: http://codereview.chromium.org/460144 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34121

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -45 lines)			Patch
	M	chrome/browser/browser_main.cc	View		5 chunks	+27 lines, -45 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Doh, I see this was backed out. What's happening with this now?

11 years ago (2009-12-10 15:43:42 UTC) #3

willchan no longer on Chromium

11 years ago (2009-12-10 16:47:29 UTC) #4

Broke the Mac startup_test.  Dunno why.  Hopefully I'll get a chance
to look into it today.

On Thu, Dec 10, 2009 at 7:43 AM,  <mark@chromium.org> wrote:
> Doh, I see this was backed out.  What's happening with this now?
>
> http://codereview.chromium.org/460154
>

Expand Messages | Collapse Messages