Issue 460135: STS: add chrome.google.com to the built in STS list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460135: STS: add chrome.google.com to the built in STS list. (Closed)

Created:
11 years ago by agl

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

STS: add chrome.google.com to the built in STS list.

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -8 lines)			Patch
M	net/base/transport_security_state.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/base/transport_security_state.cc	View	3 chunks	+35 lines, -8 lines	2 comments	Download
M	net/base/transport_security_state_unittest.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

11 years ago (2009-12-08 03:09:42 UTC) #2

I don't think we want to do this quite yet.  The gallery wasn't able to turn on
STS because they're using insecure youtube videos.  Hopefully they'll get that
resolved soon.

http://codereview.chromium.org/460135/diff/1/2
File net/base/transport_security_state.cc (right):

http://codereview.chromium.org/460135/diff/1/2#newcode352
net/base/transport_security_state.cc:352: if (host == "chrome.google.com") {
They rolled back this change because they're hosting HTTP YouTube videos.  We
shouldn't bake this in until they're ready.

http://codereview.chromium.org/460135/diff/1/2#newcode355
net/base/transport_security_state.cc:355: result->include_subdomains = true;
This should be false.

Expand Messages | Collapse Messages