Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2299)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/extensions/app_view.js

Issue 460133002: Allow passing parameters within appview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed spacing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.cc ('k') | chrome/test/data/extensions/platform_apps/app_view/shim/main.js » ('j') | chrome/test/data/extensions/platform_apps/app_view/shim/main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/app_view.js
diff --git a/chrome/renderer/resources/extensions/app_view.js b/chrome/renderer/resources/extensions/app_view.js
index 4b2296294dafc830a4614025ef1c7a2fd66c36d1..9edd9881cd513fab4be6c0b38fffe9be684d0258 100644
--- a/chrome/renderer/resources/extensions/app_view.js
+++ b/chrome/renderer/resources/extensions/app_view.js
@@ -39,14 +39,15 @@ AppViewInternal.prototype.createBrowserPluginNode = function() {
return browserPluginNode;
};
-AppViewInternal.prototype.connect = function(app, callback) {
- var params = {
- 'appId': app
+AppViewInternal.prototype.connect = function(app, params, callback) {
+ var createParams = {
+ 'appId': app,
+ 'params': params
};
var self = this;
GuestViewInternal.createGuest(
'appview',
- params,
+ createParams,
function(instanceId) {
if (!instanceId) {
self.browserPluginNode.style.visibility = 'hidden';
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.cc ('k') | chrome/test/data/extensions/platform_apps/app_view/shim/main.js » ('j') | chrome/test/data/extensions/platform_apps/app_view/shim/main.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698