Allow passing parameters within appview

chrome/browser/guest_view/app_view/app_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/app_view/app_view_guest.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/guest_view/app_view/app_view_constants.h"
@@ skipping 133 matching lines @@
     const std::string& embedder_extension_id,
     int embedder_render_process_id,
     const base::DictionaryValue& create_params,
     const WebContentsCreatedCallback& callback) {
   std::string app_id;
   if (!create_params.GetString(appview::kAppID, &app_id)) {
     callback.Run(NULL);
     return;
   }
 
+  const base::DictionaryValue* params = NULL;
+  if (!create_params.GetDictionary(appview::kParams, &params)) {
+    callback.Run(NULL);
+    return;
+  }
+
   ExtensionService* service =
       ExtensionSystem::Get(browser_context())->extension_service();
   const Extension* guest_extension = service->GetExtensionById(app_id, false);
   const Extension* embedder_extension =
       service->GetExtensionById(embedder_extension_id, false);
 
   if (!guest_extension || !guest_extension->is_platform_app() ||
       !embedder_extension | !embedder_extension->is_platform_app()) {
     callback.Run(NULL);
     return;
   }
 
   pending_response_map.Get().insert(
       std::make_pair(GetGuestInstanceID(),
                      make_linked_ptr(new ResponseInfo(
                                         guest_extension,
                                         weak_ptr_factory_.GetWeakPtr(),
                                         callback))));
 
   LazyBackgroundTaskQueue* queue =
       ExtensionSystem::Get(browser_context())->lazy_background_task_queue();
   if (queue->ShouldEnqueueTask(browser_context(), guest_extension)) {
     queue->AddPendingTask(browser_context(),
                           guest_extension->id(),
-                          base::Bind(&AppViewGuest::LaunchAppAndFireEvent,
-                                     weak_ptr_factory_.GetWeakPtr(),
-                                     callback));
+                          base::Bind(
+                              &AppViewGuest::LaunchAppAndFireEvent,
+                              weak_ptr_factory_.GetWeakPtr(),
+                              base::Passed(make_scoped_ptr(params->DeepCopy())),
+                              callback));
     return;
   }
 
   ProcessManager* process_manager =
       ExtensionSystem::Get(browser_context())->process_manager();
   ExtensionHost* host =
       process_manager->GetBackgroundHostForExtension(guest_extension->id());
   DCHECK(host);
-  LaunchAppAndFireEvent(callback, host);
+  LaunchAppAndFireEvent(make_scoped_ptr(params->DeepCopy()), callback, host);
 }
 
 void AppViewGuest::DidAttachToEmbedder() {
   // This is called after the guest process has been attached to a host
   // element. This means that the host element knows how to route input
   // events to the guest, and the guest knows how to get frames to the
   // embedder.
   guest_web_contents()->GetController().LoadURL(
       url_, content::Referrer(), content::PAGE_TRANSITION_LINK, std::string());
 }
@@ skipping 21 matching lines @@
 
   WebContents::CreateParams params(
       browser_context(),
       content::SiteInstance::CreateForURL(browser_context(),
                                           guest_extension->url()));
   params.guest_delegate = this;
   callback.Run(WebContents::Create(params));
 }
 
 void AppViewGuest::LaunchAppAndFireEvent(
+    scoped_ptr<base::DictionaryValue> params,
     const WebContentsCreatedCallback& callback,
     ExtensionHost* extension_host) {
   ExtensionSystem* system = ExtensionSystem::Get(browser_context());
   bool has_event_listener = system->event_router()->ExtensionHasEventListener(
       extension_host->extension()->id(),
       app_runtime::OnEmbedRequested::kEventName);
   if (!has_event_listener) {
     callback.Run(NULL);
     return;
   }
 
   scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue());
   embed_request->SetInteger(appview::kGuestInstanceID, GetGuestInstanceID());
   embed_request->SetString(appview::kEmbedderID, embedder_extension_id());
+  embed_request->Set(appview::kParams, params.release());
   AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(
       browser_context(), embed_request.Pass(), extension_host->extension());
 }
 
 }  // namespace extensions