Allow passing parameters within appview

chrome/test/data/extensions/platform_apps/app_view/shim/main.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var util = {};
 var embedder = {};
 embedder.baseGuestURL = '';
 embedder.emptyGuestURL = '';
 embedder.windowOpenGuestURL = '';
 embedder.noReferrerGuestURL = '';
@@ skipping 55 matching lines @@
     embedder.test.fail();
   }
 };
 
 // Tests begin.
 function testAppViewBasic(appToEmbed) {
   var appview = new AppView();
   LOG('appToEmbed  ' + appToEmbed);
   // Step 1: Attempt to connect to a non-existant app.
   LOG('attempting to connect to non-existant app.');
-  appview.connect('abc123', function(success) {
+  appview.connect('abc123', {}, function(success) {
     // Make sure we fail.
     if (success) {
       embedder.test.fail();
       return;
     }
     LOG('failed to connect to non-existant app.');
     LOG('attempting to connect to known app.');
     // Step 2: Attempt to connect to an app we know exists.
-    appview.connect(appToEmbed, function(success) {
+    appview.connect(appToEmbed, {}, function(success) {
       // Make sure we don't fail.
       if (!success) {
         embedder.test.fail();
+        return;
+      }
+      embedder.test.succeed();
+    });
+  });
+  document.body.appendChild(appview);
+};
+
+// Tests begin.
+function testAppViewParams(appToEmbed) {
+  var appview = new AppView();
+  LOG('appToEmbed  ' + appToEmbed);
+  // Step 1: Attempt to connect to an app with refused params.
+  LOG('attempting to connect to app with refused params.');
+  appview.connect(appToEmbed, { 'foo': 'bar' }, function(success) {
+    // Make sure we fail.
+    if (success) {
+      embedder.test.fail();
+      return;
+    }
+    // Step 2: Attempt to connect to an app with good params.
+    appview.connect(appToEmbed, { 'foo': 'bleep' }, function(success) {

[Xi Han, 2014/08/12 18:52:18]

I think the step 2 shouldn't be a part of the callback of the first
appview.connect(...) function. It would be better if we make it as a independent
test. Also, the LOG of the step 2 is missing.

+      // Make sure we don't fail.
+      if (!success) {
+        embedder.test.fail();
         return;
       }
       embedder.test.succeed();
     });
   });
   document.body.appendChild(appview);
 };
 
 embedder.test.testList = {
-  'testAppViewBasic': testAppViewBasic
+  'testAppViewBasic': testAppViewBasic,
+  'testAppViewParams': testAppViewParams

[Xi Han, 2014/08/12 18:52:18]

Maybe we can split the second test as two, like:
testAppViewWithRefusedParamsShouldFail,
testAppViewWithGoodParamsShouldSucceed.

 };
 
 onload = function() {
   chrome.test.getConfig(function(config) {
     embedder.setUp_(config);
     chrome.test.sendMessage('Launched');
   });
 };