Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 460113006: Mac Video Capture: expose --enable-avfoundation as tristate in chrome://flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: #ifdef using AVfoundation switches Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | media/video/capture/mac/avfoundation_glue.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 }; 482 };
483 483
484 const Experiment::Choice kEnableDropSyncCredentialChoices[] = { 484 const Experiment::Choice kEnableDropSyncCredentialChoices[] = {
485 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 485 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
486 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 486 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
487 password_manager::switches::kEnableDropSyncCredential, "" }, 487 password_manager::switches::kEnableDropSyncCredential, "" },
488 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 488 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
489 password_manager::switches::kDisableDropSyncCredential, "" }, 489 password_manager::switches::kDisableDropSyncCredential, "" },
490 }; 490 };
491 491
492 #if defined(OS_MACOSX)
493 const Experiment::Choice kEnableAVFoundationChoices[] = {
494 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
495 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, switches::kEnableAVFoundation, ""},
496 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kForceQTKit, ""}
497 };
498 #endif
499
492 // RECORDING USER METRICS FOR FLAGS: 500 // RECORDING USER METRICS FOR FLAGS:
493 // ----------------------------------------------------------------------------- 501 // -----------------------------------------------------------------------------
494 // The first line of the experiment is the internal name. If you'd like to 502 // The first line of the experiment is the internal name. If you'd like to
495 // gather statistics about the usage of your flag, you should append a marker 503 // gather statistics about the usage of your flag, you should append a marker
496 // comment to the end of the feature name, like so: 504 // comment to the end of the feature name, like so:
497 // "my-special-feature", // FLAGS:RECORD_UMA 505 // "my-special-feature", // FLAGS:RECORD_UMA
498 // 506 //
499 // After doing that, run 507 // After doing that, run
500 // tools/metrics/actions/extract_actions.py 508 // tools/metrics/actions/extract_actions.py
501 // to add the metric to actions.xml (which will enable UMA to record your 509 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1207 kOsDesktop, 1215 kOsDesktop,
1208 MULTI_VALUE_TYPE(kEnableSyncAppListChoices) 1216 MULTI_VALUE_TYPE(kEnableSyncAppListChoices)
1209 }, 1217 },
1210 #endif 1218 #endif
1211 #if defined(OS_MACOSX) 1219 #if defined(OS_MACOSX)
1212 { 1220 {
1213 "enable-avfoundation", 1221 "enable-avfoundation",
1214 IDS_FLAGS_ENABLE_AVFOUNDATION_NAME, 1222 IDS_FLAGS_ENABLE_AVFOUNDATION_NAME,
1215 IDS_FLAGS_ENABLE_AVFOUNDATION_DESCRIPTION, 1223 IDS_FLAGS_ENABLE_AVFOUNDATION_DESCRIPTION,
1216 kOsMac, 1224 kOsMac,
1217 SINGLE_VALUE_TYPE(switches::kEnableAVFoundation) 1225 MULTI_VALUE_TYPE(kEnableAVFoundationChoices)
1218 }, 1226 },
1219 #endif 1227 #endif
1220 { 1228 {
1221 "impl-side-painting", 1229 "impl-side-painting",
1222 IDS_FLAGS_IMPL_SIDE_PAINTING_NAME, 1230 IDS_FLAGS_IMPL_SIDE_PAINTING_NAME,
1223 IDS_FLAGS_IMPL_SIDE_PAINTING_DESCRIPTION, 1231 IDS_FLAGS_IMPL_SIDE_PAINTING_DESCRIPTION,
1224 kOsAll, 1232 kOsAll,
1225 MULTI_VALUE_TYPE(kImplSidePaintingChoices) 1233 MULTI_VALUE_TYPE(kImplSidePaintingChoices)
1226 }, 1234 },
1227 { 1235 {
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2442 } 2450 }
2443 2451
2444 const Experiment* GetExperiments(size_t* count) { 2452 const Experiment* GetExperiments(size_t* count) {
2445 *count = num_experiments; 2453 *count = num_experiments;
2446 return experiments; 2454 return experiments;
2447 } 2455 }
2448 2456
2449 } // namespace testing 2457 } // namespace testing
2450 2458
2451 } // namespace about_flags 2459 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | media/video/capture/mac/avfoundation_glue.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698