Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 460113006: Mac Video Capture: expose --enable-avfoundation as tristate in chrome://flags (Closed)

Created:
6 years, 4 months ago by mcasas
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mac Video Capture: expose --enable-avfoundation as tristate in chrome://flags Currently chrome://flags only exposes #enable-avfoundation as an enable link. This CL exposes instead a tristate compose of Default/Enable/Disable. BUG=356106, 396764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289053

Patch Set 1 #

Total comments: 1

Patch Set 2 : #ifdef using AVfoundation switches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/about_flags.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M media/video/capture/mac/avfoundation_glue.mm View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mcasas
vrk@ PTAL, tommi@ Owners RS/ PTAL.
6 years, 4 months ago (2014-08-12 11:16:25 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 4 months ago (2014-08-12 13:39:11 UTC) #2
vrk (LEFT CHROMIUM)
lgtm Thanks for doing this! https://codereview.chromium.org/460113006/diff/1/media/video/capture/mac/avfoundation_glue.mm File media/video/capture/mac/avfoundation_glue.mm (right): https://codereview.chromium.org/460113006/diff/1/media/video/capture/mac/avfoundation_glue.mm#newcode123 media/video/capture/mac/avfoundation_glue.mm:123: // TODO(vrk): Does this ...
6 years, 4 months ago (2014-08-12 16:10:17 UTC) #3
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 4 months ago (2014-08-12 16:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/460113006/1
6 years, 4 months ago (2014-08-12 16:12:23 UTC) #5
mcasas
The CQ bit was unchecked by mcasas@chromium.org
6 years, 4 months ago (2014-08-12 16:52:26 UTC) #6
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 4 months ago (2014-08-12 16:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/460113006/20001
6 years, 4 months ago (2014-08-12 16:56:40 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 20:01:05 UTC) #9
Message was sent while issue was closed.
Change committed as 289053

Powered by Google App Engine
This is Rietveld 408576698