Adds the audio history and always on hotwording settings.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 1760 matching lines @@
 // Holds URL patterns that specify URLs that will be granted access to video
 // capture devices without prompt.  NOTE: This whitelist is currently only
 // supported when running in kiosk mode.
 // TODO(tommi): Update comment when this is supported for all modes.
 const char kVideoCaptureAllowedUrls[] = "hardware.video_capture_allowed_urls";
 
 // A boolean pref that controls the enabled-state of hotword search voice
 // trigger.
 const char kHotwordSearchEnabled[] = "hotword.search_enabled_2";
 
+// A boolean pref that controls the enabled-state of hotword search voice
+// trigger from any screen.
+const char kHotwordAlwaysOnSearchEnabled[] = "hotword.always_on_search_enabled";

[Matt Giuca, 2014/08/12 08:37:39]

This needs to be in OS_CHROMEOS only (doesn't compile on non-CrOS build). You
should move it to just before kConsumerManagementEnrollmentState, so it matches
the order in pref_names.h.

Alternatively, maybe this pref's existence should not be guarded by OS_CHROMEOS.
Rather, just ignore it if OS_CHROMEOS is false (so that we have the possibility
of enabling it later). Either way, make sure the .h and .cc files give things in
the same order.

[Anand Mistry (off Chromium), 2014/08/12 08:46:35]

Please don't guard this with OS_CHROMEOS. It should work on regular chrome as
well.

[rpetterson, 2014/08/12 18:21:57]

+1 My understanding is that although we'll be launching on ChromeOS this will be
a feature available to power users on Chrome.

[kcarattini, 2014/08/13 03:51:54]

Done. Sorry, everyone! Leftover from before I merged with Anand's change that
moved the flag out of ChromeOS.

+
 // A boolean pref that controls whether the sound of "Ok, Google" plus a few
 // seconds of audio data before is sent back to improve voice search.
 const char kHotwordAudioLoggingEnabled[] = "hotword.audio_logging_enabled";
 
 // A string holding the locale information under which Hotword was installed.
 // It is used for comparison since the hotword voice search trigger must be
 // reinstalled to handle a new language.
 const char kHotwordPreviousLanguage[] = "hotword.previous_language";
 
 #if defined(OS_ANDROID)
@@ skipping 525 matching lines @@
 // "mapped_title" entries, detailing the bookmark target URL (if any), the title
 // given by the PartnerBookmarksProvider and either the user-visible renamed
 // title or an empty string if the bookmark node was removed.
 const char kPartnerBookmarkMappings[] = "partnerbookmarks.mappings";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 
 }  // namespace prefs