chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 72ae49594110623dbfa7d1b093a6874271eeaa35..2dc32556e59237b43f6c7d07284ed823a47493f7 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -6622,12 +6622,24 @@ Keep your key file in a safe place. You will need it to create new versions of y
         Set which search engine is used when searching from the
         <ph name="BEGIN_LINK">&lt;a target="_blank" href="$1"&gt;</ph>omnibox<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>.
       </message>
-      <message name="IDS_HOTWORD_SEARCH_PREF_CHKBOX" desc="A checkbox under Search on the Settings page to allow audio capture devices to initiate searches.">
+      <message name="IDS_HOTWORD_SEARCH_PREF_CHKBOX" desc="A checkbox under Voice on the Settings page to allow audio capture devices to initiate searches.">

[Matt Giuca, 2014/08/12 08:37:39]

It's probably not ideal to change a desc without changing the string, since it
*might* trigger a re-translation. I discussed with Ben and he said "go ahead and
change it, but remove the mention of the heading entirely so it's independent."
(So just "a checkbox on the Settings page").

Similarly, drop "under Voice" in your new descriptions.

[kcarattini, 2014/08/13 03:51:53]

Done.

         Enable "Ok Google" to start a voice search
       </message>
-      <message name="IDS_HOTWORD_SEARCH_PREF_DESCRIPTION" desc="Description of the hotword  search preference">
+      <message name="IDS_HOTWORD_SEARCH_PREF_DESCRIPTION" desc="Description of the hotword search preference">
         When you say "Ok Google," Chrome will search for what you say next.
       </message>
+      <message name="IDS_HOTWORD_ALWAYS_ON_SEARCH_PREF_CHKBOX" desc="A checkbox under Voice on the Settings page to allow audio capture devices to initiate searches from any screen.">
+        "Ok Google" detection from any screen

[Matt Giuca, 2014/08/12 08:37:39]

See my comment below; I think you should collapse the two labels into one. How
about:

Enable "Ok Google" detection from anywhere, when the screen is on

(Note: I changed "any screen" to "anywhere" since it's confusing having two
usages of "screen" in the one sentence, and also users don't really think in
terms of "screens".)

[kcarattini, 2014/08/13 03:51:53]

I've updated the strings to reflect the new Mocks the Hwi sent out today.

[Matt Giuca, 2014/08/13 05:21:08]

Acknowledged.

+      </message>
+      <message name="IDS_HOTWORD_ALWAYS_ON_SEARCH_PREF_DESCRIPTION" desc="Description of the always on hotword search preference">
+        Responds to your voice. Works when the screen is on.
+      </message>
+      <message name="IDS_HOTWORD_AUDIO_HISTORY_PREF_CHKBOX" desc="A checkbox under Voice on the Settings page that allows for sending audio of 'Ok, Google' plus a few seconds before back to Google to improve voice search.">
+        Audio History

[Matt Giuca, 2014/08/12 08:37:39]

Again, I think this should be collapsed.

Since this is the same pref as the checkbox in the confirmation dialog, I think
this should have the same text ("Improve voice search by ...") which is
IDS_HOTWORD_AUDIO_LOGGING_ENABLE. So probably don't want a new string here.

[kcarattini, 2014/08/13 03:51:53]

Same as above.

[Matt Giuca, 2014/08/13 05:21:08]

Nit: "Enable audio history" (no full-stop, no Title Case).

[kcarattini, 2014/08/13 05:34:33]

Done.

+      </message>
+      <message name="IDS_HOTWORD_AUDIO_HISTORY_PREF_DESCRIPTION" desc="Description of the audio history search preference">
+        Required for features such as using "Ok Google" to start a voice search from any screen.
+      </message>
       <message name="IDS_HOTWORD_CONFIRM_BUBBLE_TITLE" desc="The title text for the bubble to enable the hotword voice search trigger.">
         Ok Google
       </message>