Refactor ShapeOutsideInfo so it isn't mutated for each line

Refactor ShapeOutsideInfo so it isn't mutated for each line

Encapsulate the per line state into a ShapeOutsideDeltas object.
updateDeltasForContainingBlockLine has been renamed to
computeDeltasForContainingBlockLine, and it returns an instance of the
ShapeOutsideDeltas object for that line.  This object is cached, but
none of the functionality of ShapeOutsideInfo is dependant on any line
specific data anymore.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180483

[rwlbuis, 2014-08-12 15:20:44]

Looks mostly good to me, stated one suggestion.

https://codereview.chromium.org/460103002/diff/1/Source/core/rendering/shapes...
File Source/core/rendering/shapes/ShapeOutsideInfo.h (right):

https://codereview.chromium.org/460103002/diff/1/Source/core/rendering/shapes...
Source/core/rendering/shapes/ShapeOutsideInfo.h:84: LayoutUnit m_lineHeight;
I think you should group the bools together, otherwise you have more padding
than needed.

[Bem Jones-Bey (adobe), 2014-08-12 17:58:58]

On 2014/08/12 15:20:44, rwlbuis wrote:
> Looks mostly good to me, stated one suggestion.
> 
>
https://codereview.chromium.org/460103002/diff/1/Source/core/rendering/shapes...
> File Source/core/rendering/shapes/ShapeOutsideInfo.h (right):
> 
>
https://codereview.chromium.org/460103002/diff/1/Source/core/rendering/shapes...
> Source/core/rendering/shapes/ShapeOutsideInfo.h:84: LayoutUnit m_lineHeight;
> I think you should group the bools together, otherwise you have more padding
> than needed.

Thanks! That's a good point, I've updated the patch accordingly.

[leviw_travelin_and_unemployed, 2014-08-15 22:42:10]

lgtm

https://codereview.chromium.org/460103002/diff/40001/Source/core/rendering/sh...
File Source/core/rendering/shapes/ShapeOutsideInfo.h (right):

https://codereview.chromium.org/460103002/diff/40001/Source/core/rendering/sh...
Source/core/rendering/shapes/ShapeOutsideInfo.h:49: : m_leftMarginBoxDelta(0)
These constructors taking zeros aren't necessary, and actually are slower when
instantiating LayoutUnits than the default.

https://codereview.chromium.org/460103002/diff/40001/Source/core/rendering/sh...
Source/core/rendering/shapes/ShapeOutsideInfo.h:83: bool m_lineOverlapsShape;
Nit: you could pack these by explicitly sizing them. I don't think we
necessarily get that for free?

[Bem Jones-Bey (adobe), 2014-08-15 23:28:25]

The CQ bit was checked by bjonesbe@adobe.com

[commit-bot: I haz the power, 2014-08-15 23:29:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/460103002/60001

[commit-bot: I haz the power, 2014-08-16 00:37:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23018)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-16 00:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 00:58:32]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Bem Jones-Bey (adobe), 2014-08-18 18:03:23]

The CQ bit was checked by bjonesbe@adobe.com

[Bem Jones-Bey (adobe), 2014-08-18 18:03:33]

The CQ bit was unchecked by bjonesbe@adobe.com

[Bem Jones-Bey (adobe), 2014-08-18 18:04:01]

The CQ bit was checked by bjonesbe@adobe.com

[commit-bot: I haz the power, 2014-08-18 18:05:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/460103002/60001

[commit-bot: I haz the power, 2014-08-18 18:50:29]

Committed patchset #4 (60001) as 180483