Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 460093003: Disable core keyboard device as well when entering touchview. (Closed)

Created:
6 years, 4 months ago by flackr
Modified:
6 years, 4 months ago
Reviewers:
sadrul, kpschoedel
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable core keyboard device as well when entering touchview. Repeated keypress events seem to be coming from the core keyboard device for the internal keyboard. Amazingly, they seem to come from the correct device (for my external keyboard at least) so this patch may be all we need. BUG=402868 TEST=Flip open device past 180 to enter touchview. Hold a key on keyboard. Key is not typed. External keyboard still works while in touchview. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
flackr
Please take a look. It seems a little hacky but this seems to do exactly ...
6 years, 4 months ago (2014-08-12 22:08:27 UTC) #1
sadrul
+kpschoedel@ mind reviewing? :)
6 years, 4 months ago (2014-08-13 02:31:09 UTC) #2
flackr
ping
6 years, 4 months ago (2014-08-13 18:05:02 UTC) #3
kpschoedel
Sorry, missed the message. lgtm.
6 years, 4 months ago (2014-08-13 18:08:55 UTC) #4
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 4 months ago (2014-08-13 18:10:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/460093003/1
6 years, 4 months ago (2014-08-13 18:11:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 18:11:57 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-13 18:11:58 UTC) #8
flackr
On 2014/08/13 18:11:58, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 4 months ago (2014-08-13 18:54:40 UTC) #9
sadrul
lgtm
6 years, 4 months ago (2014-08-13 18:58:11 UTC) #10
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 4 months ago (2014-08-13 18:58:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/460093003/1
6 years, 4 months ago (2014-08-13 19:02:21 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 07:36:27 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 11:21:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (1) as 289524

Powered by Google App Engine
This is Rietveld 408576698