Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 460083: Split app.gyp and add a Win64 version of the app_base target.... (Closed)

Created:
11 years ago by gregoryd
Modified:
9 years, 7 months ago
Reviewers:
bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Split app.gyp and add a Win64 version of the app_base target. This is required for supporting NaCl on 64-bit Windows TEST=none BUG=28176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34009

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -209 lines) Patch
M app/app.gyp View 1 2 3 4 5 6 1 chunk +3 lines, -209 lines 0 comments Download
A app/app_base.gypi View 1 2 3 4 5 6 7 1 chunk +289 lines, -0 lines 0 comments Download
A app/l10n_util_dummy.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A app/resource_bundle_dummy.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gregoryd
11 years ago (2009-12-05 21:19:50 UTC) #1
bradn
11 years ago (2009-12-07 18:39:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698