Issue 460071: Mark a test as flaky that failed for 1/2 of yesterday on one bot. Doing fine...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460071: Mark a test as flaky that failed for 1/2 of yesterday on one bot. Doing fine... (Closed)

Created:
11 years ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Yuta Kitamura

CC:
chromium-reviews_googlegroups.com, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Mark a test as flaky that failed for 1/2 of yesterday on one bot. Doing fine on others. BUG=28445 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33815

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/worker/worker_uitest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years ago (2009-12-04 14:40:44 UTC) #3

LGTM

On Fri, Dec 4, 2009 at 9:11 AM,  <thomasvl@chromium.org> wrote:
> Reviewers: Mark Mentovai,
>
> Description:
> Mark a test as flaky that failed for 1/2 of yesterday on one bot.  Doing
> fine on
> others.
>
> BUG=28445
> TEST=none
>
> Please review this at http://codereview.chromium.org/460071
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/worker/worker_uitest.cc
>
>
> Index: chrome/worker/worker_uitest.cc
> ===================================================================
> --- chrome/worker/worker_uitest.cc      (revision 33812)
> +++ chrome/worker/worker_uitest.cc      (working copy)
> @@ -336,6 +336,10 @@
>  #if defined(OS_LINUX)
>  // Fails (crashes) on Linux Tests: http://crbug.com/28445
>  #define LimitTotal DISABLED_LimitTotal
> +#elif defined(OS_MACOSX)
> +// Doesn't crash, but on Mac it sometimes fails for a few runs in a row,
> +// http://crbug.com/28445
> +#define LimitTotal FLAKY_LimitTotal
>  #endif
>
>  TEST_F(WorkerTest, LimitTotal) {
>
>
>

Expand Messages | Collapse Messages