Refactor JavaScript support for packed boolean arrays

mojo/public/tools/bindings/generators/mojom_js_generator.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates JavaScript source files from a mojom.Module."""
 
 import mojom.generate.generator as generator
 import mojom.generate.module as mojom
 import mojom.generate.pack as pack
 from mojom.generate.template_expander import UseJinja
@@ skipping 68 matching lines @@
   mojom.STRING:       "codec.String",
 }
 
 
 def CodecType(kind):
   if kind in mojom.PRIMITIVES:
     return _kind_to_codec_type[kind]
   if isinstance(kind, mojom.Struct):
     return "new codec.PointerTo(%s)" % CodecType(kind.name)
   if isinstance(kind, mojom.Array) and kind.kind == mojom.BOOL:
-    return "new codec.ArrayOfBoolArrayPointers()"
+    return "new codec.ArrayOf(new codec.ArrayOf(codec.PackedBool))"
   if isinstance(kind, mojom.Array):
     return "new codec.ArrayOf(%s)" % CodecType(kind.kind)
   if isinstance(kind, mojom.Interface) or \
      isinstance(kind, mojom.InterfaceRequest):
     return CodecType(mojom.MSGPIPE)
   if isinstance(kind, mojom.Enum):
     return _kind_to_codec_type[mojom.INT32]
   return kind
 
 
 def JavaScriptDecodeSnippet(kind):
   if kind in mojom.PRIMITIVES:
     return "decodeStruct(%s)" % CodecType(kind)
   if isinstance(kind, mojom.Struct):
     return "decodeStructPointer(%s)" % CodecType(kind.name)
   if isinstance(kind, mojom.Array) and kind.kind == mojom.BOOL:
-    return "decodeBoolArrayPointer()"
+    return "decodeArrayPointer(new codec.ArrayOf(codec.PackedBool))"
   if isinstance(kind, mojom.Array):
     return "decodeArrayPointer(%s)" % CodecType(kind.kind)
   if isinstance(kind, mojom.Interface) or \
      isinstance(kind, mojom.InterfaceRequest):
     return JavaScriptDecodeSnippet(mojom.MSGPIPE)
   if isinstance(kind, mojom.Enum):
     return JavaScriptDecodeSnippet(mojom.INT32)
 
 
 def JavaScriptEncodeSnippet(kind):
   if kind in mojom.PRIMITIVES:
     return "encodeStruct(%s, " % CodecType(kind)
   if isinstance(kind, mojom.Struct):
     return "encodeStructPointer(%s, " % CodecType(kind.name)
-  if isinstance(kind, mojom.Array) and kind.kind == mojom.BOOL:
-    return "encodeBoolArrayPointer(";
+  if isinstance(kind, (mojom.Array, mojom.FixedArray)) and \
+     kind.kind == mojom.BOOL:
+    return "encodeArrayPointer(new codec.ArrayOf(codec.PackedBool), ";
   if isinstance(kind, (mojom.Array, mojom.FixedArray)):
     return "encodeArrayPointer(%s, " % CodecType(kind.kind)
   if isinstance(kind, mojom.Interface) or \
      isinstance(kind, mojom.InterfaceRequest):
     return JavaScriptEncodeSnippet(mojom.MSGPIPE)
   if isinstance(kind, mojom.Enum):
     return JavaScriptEncodeSnippet(mojom.INT32)
 
 
 def TranslateConstants(token):
@@ skipping 50 matching lines @@
     self.Write(self.GenerateJsModule(), "%s.js" % self.module.name)
 
   def GetImports(self):
     # Since each import is assigned a variable in JS, they need to have unique
     # names.
     counter = 1
     for each in self.module.imports:
       each["unique_name"] = "import" + str(counter)
       counter += 1
     return self.module.imports