Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 460062: Hook up V8 idle notifications for extension prcoesses. (Closed)

Created:
11 years ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Hook up V8 idle notifications for extension prcoesses. We reset the idle timer after any activity, which includes an extension event or message, or a new extension view being created. The timer runs after 10 seconds of idleness. BUG=29329 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34002

Patch Set 1 #

Patch Set 2 : use timers #

Patch Set 3 : fixed initial timers #

Total comments: 7

Patch Set 4 : crash fix #

Patch Set 5 : initial timer #

Patch Set 6 : dampen max timer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -26 lines) Patch
M chrome/renderer/render_thread.h View 1 2 3 4 5 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 3 4 5 7 chunks +50 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Perry
11 years ago (2009-12-04 20:01:56 UTC) #1
Matt Perry
11 years ago (2009-12-04 20:04:23 UTC) #2
Mike Belshe
http://codereview.chromium.org/460062/diff/2001/2002 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/460062/diff/2001/2002#newcode96 chrome/renderer/render_thread.cc:96: static const int64 kMaxExtensionIdleHandlerDelayS = 10*60 /* seconds */; ...
11 years ago (2009-12-04 22:37:50 UTC) #3
Matt Perry
http://codereview.chromium.org/460062/diff/2001/2002 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/460062/diff/2001/2002#newcode96 chrome/renderer/render_thread.cc:96: static const int64 kMaxExtensionIdleHandlerDelayS = 10*60 /* seconds */; ...
11 years ago (2009-12-04 23:10:56 UTC) #4
Erik does not do reviews
LGTM I'm not sure about the delays you chose, but I'm not sure how to ...
11 years ago (2009-12-05 15:09:47 UTC) #5
Erik does not do reviews
11 years ago (2009-12-07 20:33:41 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698