Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 460060: Code generation for multiply-by-constant-smi.... (Closed)

Created:
11 years ago by sra1
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Code gen improvements for multiply and logical shift. Code generation for multiply-by-constant-smi: For positive constant values the negative-zero check is eliminated. For negative constant values the negative-zero check is simpified. Special cases for constants -1, 0, and 1. Improve UnarySubStub for Smi case to use the jo/jz trick. Improved code sequence for x >>> k. For k = 0/1/n the old inline code was 8/8/6 instructions, is now 2/4/5 instructions.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -31 lines) Patch
M src/ia32/codegen-ia32.cc View 1 2 3 4 chunks +94 lines, -31 lines 0 comments Download
M test/mjsunit/smi-ops.js View 1 2 3 1 chunk +151 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
11 years ago (2009-12-07 05:49:54 UTC) #1
Mads Ager (chromium)
11 years ago (2009-12-07 08:19:56 UTC) #2
Kevin, could you have a look at this one?

Powered by Google App Engine
This is Rietveld 408576698