Issue 460055: Split installer.gyp and add installer_util_nacl_win64 target....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460055: Split installer.gyp and add installer_util_nacl_win64 target.... (Closed)

Created:
11 years ago by gregoryd

Modified:
9 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Split installer.gyp and add installer_util_nacl_win64 target. This is required for supporting NaCl on 64-bit Windows. 32-bit and 64-bit versions of the installer_util target are now defined in installer_util.gypi and share some of the settings. TEST=none BUG=28176 Committed: revision 33932

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -77 lines)			Patch
	M	chrome/installer/installer.gyp	View	1 2 3 4	1 chunk	+6 lines, -77 lines	0 comments	Download
	A	chrome/installer/installer_util.gypi	View	1 2	1 chunk	+129 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/460055/diff/1/3 File chrome/installer/installer.gyp (right): http://codereview.chromium.org/460055/diff/1/3#newcode8 chrome/installer/installer.gyp:8: 'includes': [ Maybe add a comment in here ...

11 years ago (2009-12-04 00:08:25 UTC) #2

gregoryd

11 years ago (2009-12-04 00:21:34 UTC) #3

http://codereview.chromium.org/460055/diff/1/3
File chrome/installer/installer.gyp (right):

http://codereview.chromium.org/460055/diff/1/3#newcode8
chrome/installer/installer.gyp:8: 'includes': [
On 2009/12/04 00:08:25, bradn wrote:
> Maybe add a comment in here indicating that more targets live in the gypi and
> why its needed.

Done.

Expand Messages | Collapse Messages