Issue 460009: Merge 33380 - This fixes an issue where view source on a local file would ret...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460009: Merge 33380 - This fixes an issue where view source on a local file would ret... (Closed)

Created:
11 years ago by Mark Larson (Google)

Modified:
9 years, 7 months ago

Reviewers:
Greg Spencer (Chromium), Greg Spencer

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 33380 - This fixes an issue where view source on a local file would return a blank page. This bug was introduced by the fix for issue 26129 (r30418), which was to limit view source so that it wouldn't be able to load javascript or data URLs, but that change forgot to allow file urls. This fixes the above omission by allowing file URLs again. TEST=works:viewsource:file:///tmp/test.html, doesn't work:viewsource:javascript:alert('foo') BUG=27409 Review URL: http://codereview.chromium.org/434094 TBR=gspencer@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33544

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/browser_url_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages