Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 460003003: Update cpplint.py to r136. (Closed)

Created:
6 years, 4 months ago by Alex Vakulenko (Google)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Update cpplint.py to r136. The only difference compared to upstream[1] is the shebang line from depot_tools. [1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?r=136 BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -91 lines) Patch
M cpplint.py View 51 chunks +465 lines, -91 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Alex Vakulenko (Google)
6 years, 4 months ago (2014-08-11 19:36:22 UTC) #1
Elliot Glaysher
lgtm
6 years, 4 months ago (2014-08-11 19:44:19 UTC) #2
Alex Vakulenko (Google)
The CQ bit was checked by avakulenko@google.com
6 years, 4 months ago (2014-08-11 19:45:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/460003003/1
6 years, 4 months ago (2014-08-11 19:46:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 19:50:51 UTC) #5
commit-bot: I haz the power
Presubmit check for 460003003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-11 19:50:52 UTC) #6
Alex Vakulenko (Google)
Apparently I need to have LGTM from one of the OWNERs of depot_tools to publish ...
6 years, 4 months ago (2014-08-11 19:54:34 UTC) #7
M-A Ruel
lgtm
6 years, 4 months ago (2014-08-11 20:17:53 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 20:20:58 UTC) #9
Message was sent while issue was closed.
Change committed as 288783

Powered by Google App Engine
This is Rietveld 408576698