Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460001: Clean up to move NewStringCopy from util to chromoes/string. (Closed)

Created:
11 years ago by Sean Parent
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Clean up to move NewStringCopy from util to chromoes/string.

Patch Set 1 #

Patch Set 2 : rm src/common/unittests #

Total comments: 4

Patch Set 3 : Removed pw file, changed include format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M .gitignore View 3 chunks +14 lines, -0 lines 0 comments Download
M src/common/SConstruct View 1 chunk +1 line, -2 lines 0 comments Download
M src/common/chromeos/string.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/chromeos/string.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
D src/common/util.h View 1 chunk +0 lines, -6 lines 0 comments Download
D src/common/util.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sean Parent
Some minor cleanup before I split cros - this spans both repos. See 459006
11 years ago (2009-12-02 00:52:27 UTC) #1
DaveMoore
LGTM
11 years ago (2009-12-02 01:00:02 UTC) #2
DaveMoore
I spoke too soon. http://codereview.chromium.org/460001/diff/11/14 File src/common/chromeos/string.cc (right): http://codereview.chromium.org/460001/diff/11/14#newcode10 src/common/chromeos/string.cc:10: #include <base/logging.h> Should be "" ...
11 years ago (2009-12-02 01:04:51 UTC) #3
DaveMoore
And still too soon. http://codereview.chromium.org/460001/diff/11/18 File src/scripts/shared_user_passwd.txt (right): http://codereview.chromium.org/460001/diff/11/18#newcode1 src/scripts/shared_user_passwd.txt:1: $1$0md/mvQQ$ZYhYA5qPaLFH3/9PtkP6h1 Why is this here?
11 years ago (2009-12-02 01:05:31 UTC) #4
Sean Parent
Done - but please review the document I just shared with you. http://codereview.chromium.org/460001/diff/11/14 File src/common/chromeos/string.cc ...
11 years ago (2009-12-10 00:38:34 UTC) #5
DaveMoore
11 years ago (2009-12-10 22:41:54 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698