Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

Issue 459983002: Kill ui.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
diff --git a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
index 93d7e0e78845366ce66cdecdda482dbe5800298d..613a69730d68a62ac29796a74bdcf50d566fa776 100644
--- a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
+++ b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
@@ -12,32 +12,18 @@ found in the LICENSE file.
module("ct-embedded-flakiness-dashboard");
asyncTest("url", 1, function() {
- var oldUrlForEmbeddedFlakinessDashboard = ui.urlForEmbeddedFlakinessDashboard;
- var reset = function() {
- ui.urlForEmbeddedFlakinessDashboard = oldUrlForEmbeddedFlakinessDashboard;
- }
+ var failure = new CTFailure('foo_tests', 'foo/bar.html');
+ var tree = "blink";
+ var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
- try {
- ui.urlForEmbeddedFlakinessDashboard = function(test, step, tree) { return "about:blank#" + test + step + tree; }
- var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
- var testName = "foo/bar.html";
- var step = "foo_tests";
- var tree = "blink";
- embeddedFlakinessDashboard.test = {
- testName: testName,
- step: step,
- };
- embeddedFlakinessDashboard.tree = tree;
-
- requestAnimationFrame(function() {
- var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
- equal(iframe.src, ui.urlForEmbeddedFlakinessDashboard(testName, step, tree));
- reset();
- start();
- });
- } catch (e) {
- reset();
- }
+ embeddedFlakinessDashboard.test = failure;
+ embeddedFlakinessDashboard.tree = tree;
+
+ requestAnimationFrame(function() {
+ var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
+ equal(iframe.src, failure.urlForEmbeddedFlakinessDashboard(tree));
+ start();
+ });
});
asyncTest("heightChanged", 1, function() {

Powered by Google App Engine
This is Rietveld 408576698