components/bookmarks/common/android/bookmark_type_list.h - Issue 459973004: [Android] EnhancedBookmarksBridge for bookmark description read&write.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/common/android/bookmark_type_list.h

Issue 459973004: [Android] EnhancedBookmarksBridge for bookmark description read&write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed patchset 3 comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/common/android/OWNERS ('K') | « components/bookmarks/common/android/bookmark_type.h ('k') | components/bookmarks/common/android/component_jni_registrar.h » ('j') | components/enhanced_bookmarks/android/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/common/android/bookmark_type_list.h

diff --git a/components/cronet/android/org_chromium_net_UrlRequest_error_list.h b/components/bookmarks/common/android/bookmark_type_list.h

similarity index 51%

copy from components/cronet/android/org_chromium_net_UrlRequest_error_list.h

copy to components/bookmarks/common/android/bookmark_type_list.h

index 4f4cdb8c9cd5447c39d17c66fa9b26434d89e315..e0a65948d0258503ed6f9a9cce0fc9e37144a8a2 100644

--- a/components/cronet/android/org_chromium_net_UrlRequest_error_list.h

+++ b/components/bookmarks/common/android/bookmark_type_list.h

@@ -4,11 +4,10 @@

// This file intentionally does not have header guards, it's included

// inside a macro to generate enum values.

-#ifndef DEFINE_REQUEST_ERROR

-#error "DEFINE_REQUEST_ERROR should be defined before including this file"

+#ifndef DEFINE_BOOKMARK_TYPE

+#error "DEFINE_BOOKMARK_TYPE should be defined before including this file"

#endif

-DEFINE_REQUEST_ERROR(SUCCESS, 0)

-DEFINE_REQUEST_ERROR(UNKNOWN, 1)

-DEFINE_REQUEST_ERROR(MALFORMED_URL, 2)

-DEFINE_REQUEST_ERROR(CONNECTION_TIMED_OUT, 3)

-DEFINE_REQUEST_ERROR(UNKNOWN_HOST, 4)

+DEFINE_BOOKMARK_TYPE(NORMAL, 0)

+DEFINE_BOOKMARK_TYPE(PARTNER, 1)