Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: minidump/minidump_writable.h

Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_writable.h
diff --git a/minidump/minidump_writable.h b/minidump/minidump_writable.h
index 32ed81e714d3c73f7c06506fd138af2f12b87ed9..15876d4896acede4bb6210620d9be13e2a21612a 100644
--- a/minidump/minidump_writable.h
+++ b/minidump/minidump_writable.h
@@ -259,8 +259,11 @@ class MinidumpWritable {
virtual bool WriteObject(FileWriterInterface* file_writer) = 0;
private:
- std::vector<RVA*> registered_rvas_;
+ std::vector<RVA*> registered_rvas_; // weak
+
+ // weak
std::vector<MINIDUMP_LOCATION_DESCRIPTOR*> registered_location_descriptors_;
+
size_t leading_pad_bytes_;
State state_;

Powered by Google App Engine
This is Rietveld 408576698