Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: minidump/minidump_writable.h

Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_test_util.cc ('k') | minidump/minidump_writable_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 //! \param[in] file_writer The file writer to receive the object’s content. 252 //! \param[in] file_writer The file writer to receive the object’s content.
253 //! 253 //!
254 //! \return `true` on success. `false` on error, indicating that the content 254 //! \return `true` on success. `false` on error, indicating that the content
255 //! could not be written to the minidump file. 255 //! could not be written to the minidump file.
256 //! 256 //!
257 //! \note Valid in #kStateWritable. The object will transition to 257 //! \note Valid in #kStateWritable. The object will transition to
258 //! #kStateWritten after this method returns. 258 //! #kStateWritten after this method returns.
259 virtual bool WriteObject(FileWriterInterface* file_writer) = 0; 259 virtual bool WriteObject(FileWriterInterface* file_writer) = 0;
260 260
261 private: 261 private:
262 std::vector<RVA*> registered_rvas_; 262 std::vector<RVA*> registered_rvas_; // weak
263
264 // weak
263 std::vector<MINIDUMP_LOCATION_DESCRIPTOR*> registered_location_descriptors_; 265 std::vector<MINIDUMP_LOCATION_DESCRIPTOR*> registered_location_descriptors_;
266
264 size_t leading_pad_bytes_; 267 size_t leading_pad_bytes_;
265 State state_; 268 State state_;
266 269
267 DISALLOW_COPY_AND_ASSIGN(MinidumpWritable); 270 DISALLOW_COPY_AND_ASSIGN(MinidumpWritable);
268 }; 271 };
269 272
270 } // namespace internal 273 } // namespace internal
271 } // namespace crashpad 274 } // namespace crashpad
272 275
273 #endif // CRASHPAD_MINIDUMP_MINIDUMP_WRITABLE_H_ 276 #endif // CRASHPAD_MINIDUMP_MINIDUMP_WRITABLE_H_
OLDNEW
« no previous file with comments | « minidump/minidump_test_util.cc ('k') | minidump/minidump_writable_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698