Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.cc

Issue 459953002: Migrate geolocation permissions to the new common permission class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_bubble_request_impl.cc
diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.cc b/chrome/browser/content_settings/permission_bubble_request_impl.cc
index 21388305a21d01b72277281963bb73ac887a405f..3876ca5c549478d255dd60e7e8a1c50f46d6faff 100644
--- a/chrome/browser/content_settings/permission_bubble_request_impl.cc
+++ b/chrome/browser/content_settings/permission_bubble_request_impl.cc
@@ -37,6 +37,9 @@ PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
int PermissionBubbleRequestImpl::GetIconID() const {
int icon_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ icon_id = IDR_INFOBAR_GEOLOCATION;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
icon_id = IDR_INFOBAR_DESKTOP_NOTIFICATIONS;
@@ -58,6 +61,9 @@ int PermissionBubbleRequestImpl::GetIconID() const {
base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
int message_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ message_id = IDS_GEOLOCATION_INFOBAR_QUESTION;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
message_id = IDS_NOTIFICATION_PERMISSIONS;
@@ -84,6 +90,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {
int message_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ message_id = IDS_GEOLOCATION_INFOBAR_PERMISSION_FRAGMENT;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
message_id = IDS_NOTIFICATION_PERMISSIONS_FRAGMENT;

Powered by Google App Engine
This is Rietveld 408576698