Issue 459913002: MIPS: Fix test-simplified-lowering to pass without tf implemention.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459913002: MIPS: Fix test-simplified-lowering to pass without tf implemention. (Closed)

Created:
6 years, 4 months ago by paul.l...

Modified:
6 years, 4 months ago

Reviewers:
titzer, dusmil.imgtec, danno, Michael Starzinger, akos.palfi.imgtec

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS: Fix test-simplified-lowering to pass without tf implemention. GenerateCode() only for SupportedTarget() in 3 places, as in the other tests here. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23055

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	test/cctest/compiler/test-simplified-lowering.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

paul.l...

Committed patchset #1 manually as 23055 (presubmit successful).

6 years, 4 months ago (2014-08-11 18:54:47 UTC) #3

titzer

6 years, 4 months ago (2014-08-12 07:53:54 UTC) #4

Message was sent while issue was closed.

On 2014/08/11 18:54:47, paul.l... wrote:
> Committed patchset #1 manually as 23055 (presubmit successful).

Actually, I have a fix for that in https://codereview.chromium.org/457343003/,
but it didn't get reviewed yesterday. Should have sent it to mstarzinger@ !

Thanks Paul.

Expand Messages | Collapse Messages