mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 0164c2d49175472d2ee0a0dc2f2a90f8f6631417..17f75b6f08a47340eed2b2ca4d5e5b5add7c47ad 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -22,7 +22,7 @@ p{{loop.index}}.Pass()

mojo::MakeProxy<{{param.kind|get_name_for_kind}}>(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}})))

{%- elif param.kind|is_interface_request_kind -%}

mojo::MakeRequest<{{param.kind.kind|get_name_for_kind}}>(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}})))

-{%- elif param.kind|is_handle_kind -%}

+{%- elif param.kind|is_any_handle_kind -%}

mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}}))

{%- elif param.kind|is_enum_kind -%}

static_cast<{{param.kind|cpp_wrapper_type}}>(params->{{param.name}})

@@ -61,7 +61,7 @@ params->{{param.name}}

{%- elif param.kind|is_interface_request_kind %}

// Delegate handle.

params->{{param.name}} = in_{{param.name}}.PassMessagePipe().release();

-{%- elif param.kind|is_handle_kind %}

+{%- elif param.kind|is_any_handle_kind %}

params->{{param.name}} = in_{{param.name}}.release();

{%- else %}

params->{{param.name}} = in_{{param.name}};