|
Revert of Revert of DevTools: Introduce module initializers ( https://codereview.chromium.org/458753003/)
Reason for revert:
Un-reverting at request of patch author.
Original issue's description:
> Revert of DevTools: Introduce module initializers ( https://codereview.chromium.org/451713002/)
>
> Reason for revert:
> Breaks android_aosp bot and prevents Blink roll.
>
> http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4536/steps/compile/logs/stdio
>
> make: *** No rule to make target `out/target/product/generic/obj/GYP/shared_intermediates/resources/inspector/documentation/DocumentationView.js', needed by `out/target/product/generic/obj/GYP/shared_intermediates/devtools/devtools_resources.grd'. Stop.
>
>
> Original issue's description:
> > DevTools: Introduce module initializers
> >
> > For all lazy-loaded modules and workers, _module.js files are introduced, which
> > importScript() all scripts for a particular module.
> >
> > This allows to:
> > - get rid of importScript() calls intertwined with meaningful code,
> > - simplify module loading, since Runtime does not need to read the
> > module descriptor to determine the resource names.
> >
> > This approach is similar to how we implement
> > the CSS loading in inspector.css.
> >
> > R=pfeldman, vsevik
> > BUG= 391566
> >
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948
>
> TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG= 391566
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179963
TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 391566
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179965
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+613 lines, -367 lines) |
Patch |
 |
M |
LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/inspector/editor/editor-test.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/inspector/elements/styles/style-formatter.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/inspector/sources/debugger/script-extract-outline.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/inspector/sources/debugger/script-formatter.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/BUILD.gn
|
View
|
|
3 chunks |
+43 lines, -58 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/devtools.gyp
|
View
|
|
18 chunks |
+51 lines, -51 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/devtools.gypi
|
View
|
|
11 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/Runtime.js
|
View
|
|
2 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/audits/AuditsPanel.js
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/audits/_module.js
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/audits/module.json
|
View
|
|
1 chunk |
+10 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/console/ConsolePanel.js
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/console/_module.js
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/console/module.json
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/devices/_module.js
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/devices/module.json
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/documentation/DocumentationView.js
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/documentation/_module.js
|
View
|
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/documentation/module.json
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/elements/ElementsPanel.js
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/elements/_module.js
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/elements/module.json
|
View
|
|
2 chunks |
+15 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/extensions/ExtensionServer.js
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/extensions/_module.js
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/extensions/module.json
|
View
|
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/heap_snapshot_worker/HeapSnapshotWorker.js
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/heap_snapshot_worker/_module.js
|
View
|
|
1 chunk |
+15 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/layers/LayersPanel.js
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/layers/_module.js
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/layers/module.json
|
View
|
|
1 chunk |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/main/_module.js
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/network/NetworkPanel.js
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/network/_module.js
|
View
|
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/network/module.json
|
View
|
|
1 chunk |
+15 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/profiler/HeapSnapshotProxy.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/profiler/ProfilesPanel.js
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/profiler/_module.js
|
View
|
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/profiler/module.json
|
View
|
|
1 chunk |
+17 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/resources/ResourcesPanel.js
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/resources/_module.js
|
View
|
|
1 chunk |
+14 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/resources/module.json
|
View
|
|
1 chunk |
+13 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/script_formatter_worker/JavaScriptFormatter.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js
|
View
|
|
2 chunks |
+2 lines, -13 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/script_formatter_worker/_module.js
|
View
|
|
1 chunk |
+15 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/sdk/CSSParser.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/settings/SettingsScreen.js
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/settings/_module.js
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/settings/module.json
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/source_frame/SourceFrame.js
|
View
|
|
2 chunks |
+0 lines, -26 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/source_frame/_module.js
|
View
|
|
1 chunk |
+30 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/source_frame/module.json
|
View
|
|
1 chunk |
+27 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/sources/FilteredItemSelectionDialog.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/sources/ScriptFormatter.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/sources/SourcesPanel.js
|
View
|
|
1 chunk |
+0 lines, -32 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/sources/_module.js
|
View
|
|
1 chunk |
+36 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/sources/module.json
|
View
|
|
1 chunk |
+31 lines, -2 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/temp_storage_shared_worker/_module.js
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/timeline/TimelinePanel.js
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
 |
A |
Source/devtools/front_end/timeline/_module.js
|
View
|
|
1 chunk |
+30 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/front_end/timeline/module.json
|
View
|
|
1 chunk |
+28 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/devtools/scripts/compile_frontend.py
|
View
|
|
6 chunks |
+17 lines, -30 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/scripts/concatenate_module_descriptors.py
|
View
|
|
3 chunks |
+16 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/devtools/scripts/inline_js_imports.py
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|