Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 459753002: Fix crash when when detecting if LocalFrame is main frame (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
eustas, alph
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix crash when when detecting if LocalFrame is main frame BUG=402043 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 4 months ago (2014-08-11 07:08:39 UTC) #1
eustas
lgtm
6 years, 4 months ago (2014-08-11 07:09:22 UTC) #2
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 07:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/459753002/1
6 years, 4 months ago (2014-08-11 07:10:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 08:15:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:27:06 UTC) #6
Message was sent while issue was closed.
Change committed as 179920

Powered by Google App Engine
This is Rietveld 408576698