Issue 45973003: ash: Rename LauncherIconObserver to ShelfIconObserver.

Issue 45973003: ash: Rename LauncherIconObserver to ShelfIconObserver. (Closed)

Created:
7 years, 1 month ago by tfarina

Modified:
7 years, 1 month ago

Reviewers:
Harry McCleave, James Cook

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ash: Rename LauncherIconObserver to ShelfIconObserver. And moves from launcher/ to shelf/ directory. BUG=248353 TEST=None, no behavior changes. R=harrym@chromium.org,jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231738

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -67 lines)			Patch
M	ash/ash.gyp	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	ash/launcher/launcher.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/launcher/launcher.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	ash/launcher/launcher_icon_observer.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
A	ash/shelf/shelf_icon_observer.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	ash/shelf/shelf_view.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/shelf/shelf_view.cc	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/shelf/shelf_view_unittest.cc	View		7 chunks	+12 lines, -12 lines	0 comments	Download
M	ash/wm/app_list_controller.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/wm/app_list_controller.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/wm/panels/panel_layout_manager.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/wm/panels/panel_layout_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/45973003/1

7 years, 1 month ago (2013-10-28 21:43:22 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-10-28 22:05:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/45973003/190001

7 years, 1 month ago (2013-10-29 23:16:58 UTC) #6

Message was sent while issue was closed.

Change committed as 231738