Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 459663002: Revert of Add some performance testing for paint invalidations (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
CC:
blink-reviews, esprehn, tonyg
Project:
blink
Visibility:
Public.

Description

Revert of Add some performance testing for paint invalidations (https://codereview.chromium.org/450813002/) Reason for revert: Timing out on perf bots. One example: http://chromegw/i/chromium.perf/builders/Linux%20Perf%20%281%29/builds/2268/steps/blink_perf/logs/stdio Original issue's description: > Add some performance testing for paint invalidations > > After moving paint invalidations after compositing updates, we > lost most of the performance coverage we had as most performance > tests trigger layout without generating a frame. > > The new cases are DRT specific as we use > Internals.forceCompositingUpdate. This is required as rAF > will cap the tests to the sync frequency. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179881 TBR=dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org,xianxianzhu@chromium.org,jchaffraix@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -135 lines) Patch
D PerformanceTests/PaintInvalidation/grow-shrink-rectangle-invalidate-overlapping.html View 1 chunk +0 lines, -45 lines 0 comments Download
D PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html View 1 chunk +0 lines, -46 lines 0 comments Download
D PerformanceTests/PaintInvalidation/shift-rectangle-translateX-invalidate.html View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of Add some performance testing for paint invalidations
6 years, 4 months ago (2014-08-09 17:28:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/459663002/1
6 years, 4 months ago (2014-08-09 17:29:24 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 17:29:44 UTC) #3
Message was sent while issue was closed.
Change committed as 179886

Powered by Google App Engine
This is Rietveld 408576698